Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make taxon comparable#11329

Merged
pamil merged 1 commit into
Sylius:1.7from
oallain:doctrine-resources-comparable
Apr 7, 2020
Merged

Make taxon comparable#11329
pamil merged 1 commit into
Sylius:1.7from
oallain:doctrine-resources-comparable

Conversation

@oallain
Copy link
Copy Markdown
Contributor

@oallain oallain commented Apr 5, 2020

Q A
Branch? 1.6
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10797
License MIT

Is this good for you?
Do you think I should do the same for all resources (as said in the issue commands)?

@oallain oallain requested a review from a team as a code owner April 5, 2020 09:00
@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Apr 6, 2020
@lchrusciel lchrusciel added the RFC Discussions about potential changes or new features. label Apr 6, 2020
Zales0123
Zales0123 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm always careful when we discuss should sth be done everywhere or nowhere 😄 So I would definitely go with this fix and for other entities where the problem has been detected... And then make a conscious decision is it good to do it for others as well :) 🖖

@pamil pamil changed the base branch from master to 1.7 April 7, 2020 10:03
@pamil pamil force-pushed the doctrine-resources-comparable branch from 9997530 to f5c12d0 Compare April 7, 2020 10:03
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 7, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "doctrine-resources-comparable" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 0343931 into Sylius:1.7 Apr 7, 2020
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 7, 2020

Thanks, @oallain! 🎉

@pamil pamil mentioned this pull request Apr 7, 2020
Closed
@robgwin
Copy link
Copy Markdown

robgwin commented May 19, 2020 •
edited
Loading

I've run into the same error when changing the position of existing variants. Reported here: #11487

@oallain oallain mentioned this pull request Jun 15, 2020
Merged
lchrusciel added a commit that referenced this pull request Jul 6, 2020
@lchrusciel
bug #11580 make product variant comparable (oallain)
ed28c9f 
This PR was merged into the 1.7 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #11487, like as #11329
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.6 or 1.7 branches (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

f7c0dd5 make product variant comparable
@Loocos
Copy link
Copy Markdown

Loocos commented Mar 10, 2022

@Zales0123 I just got this on Product (Sylius v1.8.12). Using this solution helped me to fix it.
Should it be added too in core project ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced. RFC Discussions about potential changes or new features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Nesting level too deep - recursive dependency For Taxon model

6 participants

@oallain @pamil @robgwin @Loocos @Zales0123 @lchrusciel