[API] Registering shop users#11356
Merged
Merged
Conversation
lchrusciel
reviewed
Apr 15, 2020
| # 'App\Message\YourMessage': async | ||
|
|
||
| buses: | ||
| messenger.bus.default: |
Contributor
There was a problem hiding this comment.
WDYT about prefixing this bus with some sylius keyword?
Also, WDYT about defining a default bus? This way, all of the plugins could use the same main bus.
Plus, this file should be part of Api/CoreBundle, so we can share this configuration with third party users.
Contributor
Author
There was a problem hiding this comment.
I'm not sure if I should tackle this issue in this PR - what about creating an issue about that to keep track of it, not to grow this PR even bigger.
pamil
commented
Apr 15, 2020
5b71d57 to
ee7fd51
Compare
GSadee
approved these changes
Apr 15, 2020
ee7fd51 to
adcf83a
Compare
0a10cbf to
7b11178
Compare
Tomanhez
approved these changes
Apr 16, 2020
lchrusciel
approved these changes
Apr 16, 2020
| run_command "git fetch origin $TRAVIS_BRANCH:refs/remotes/origin/$TRAVIS_BRANCH" || exit $? # Make origin/master available for is_suitable steps | ||
| run_command "phpenv config-rm xdebug.ini" # Disable XDebug | ||
| run_command "echo \"memory_limit=4096M\" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini" || exit $? # Increase memory limit to 4GB | ||
| run_command "echo \"memory_limit=6144M\" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini" || exit $? # Increase memory limit to 4GB |
Contributor
There was a problem hiding this comment.
Suggested change
| run_command "echo \"memory_limit=6144M\" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini" || exit $? # Increase memory limit to 4GB | |
| run_command "echo \"memory_limit=6144M\" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini" || exit $? # Increase memory limit to 6GB |
| install_package="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/install-package" | ||
|
|
||
| locate_packages | parallel -j "$(get_number_of_jobs_for_parallel)" --gnu "${install_package} {} $* $(reset_cache)" | ||
| locate_packages | parallel -j1 --gnu "${install_package} {} $* $(reset_cache)" |
Contributor
There was a problem hiding this comment.
Why do we need this change?
| use Sylius\Component\User\Canonicalizer\CanonicalizerInterface; | ||
| use Symfony\Component\Messenger\Handler\MessageHandlerInterface; | ||
|
|
||
| class RegisterShopUserHandler implements MessageHandlerInterface |
Contributor
There was a problem hiding this comment.
I thought about opening RegisterShopUser only. Imho, this class could be finalized
Contributor
|
Thank you, Kamil! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Apr 16, 2020
…iding customer to a separate service (GSadee) This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes for review from #11356 | License | MIT Commits ------- 501c2ab Move messenger config to bundles e5f9696 Extract providing customer to separate service a6e2f53 [Travis] Fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to customise the test API client to not force
adminprefix in further PRs.