Error on show product without pricing#11400
Merged
Merged
Conversation
lchrusciel
reviewed
Apr 27, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Hello Olivier,
thanks a lot for your contribution. Can you, however, cover this case with behat, please? Just to avoid regression in the future
pamil
reviewed
May 6, 2020
Zales0123
reviewed
May 7, 2020
| /** | ||
| * @Then I should not see price for channel :channelName | ||
| */ | ||
| public function iShouldNotSeePriceForChannel(string $channelName) |
| $channelPriceRow = $this->getDocument()->find('css', sprintf('#pricing tr:contains("%s")', $channelName)); | ||
|
|
||
| if (null === $channelPriceRow) { | ||
| return ''; |
Contributor
There was a problem hiding this comment.
Maybe null? It clearly says that there is no price rather than there is something but empty 💃
|
|
||
| public function countChannels(): int | ||
| { | ||
| if (! $this->hasElement('channels')) { |
pamil
approved these changes
May 13, 2020
Contributor
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Contributor
|
Thank you, @oallain! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behat :
Before fix step
Then I should see product name "Iron shield"throw error in cause of error 500 in page.After fix, all steps are green ✔️