Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ensure swagger docs route matches the configured new api route#11544

Merged
lchrusciel merged 3 commits into
Sylius:masterfrom
Inventis:fix-hardcoded-api-route
Jul 22, 2020
Merged

ensure swagger docs route matches the configured new api route#11544
lchrusciel merged 3 commits into
Sylius:masterfrom
Inventis:fix-hardcoded-api-route

Conversation

@esserj
Copy link
Copy Markdown
Contributor

@esserj esserj commented Jun 3, 2020

fixes #11483

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11483
License MIT

when you change the new api route in the parameters, it will now correctly reflect in the documentation

@esserj esserj requested a review from a team as a code owner June 3, 2020 08:17
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Jun 3, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

Hello Jan!

Thank you very much for your contribution :)

@esserj
Copy link
Copy Markdown
Contributor Author

esserj commented Jun 3, 2020

@lchrusciel your most welcome, thanks for making an awesome e-commerce platform!

committed the oneline comment suggestions

@lchrusciel
Copy link
Copy Markdown
Contributor

Hello Jan,

could you rebase to the newest master? The build should be fixed then

@esserj esserj force-pushed the fix-hardcoded-api-route branch from 18aa493 to a746278 Compare July 16, 2020 13:38
@esserj
Copy link
Copy Markdown
Contributor Author

esserj commented Jul 16, 2020

🤞

Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jan,

thanks a lot for your contribution, and welcome among Sylius contributors 🎉

@lchrusciel lchrusciel merged commit dc98a9a into Sylius:master Jul 22, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

Thank you, Jan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded new-api route in Swagger Documentation normalizers

3 participants