Use a placeholder in tracking code sentence in shipment email#11609
Merged
Conversation
10601ef to
4118154
Compare
4118154 to
6fd3abc
Compare
lchrusciel
reviewed
Jun 30, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Hey Jacques,
Thanks for your contribution. This change absolutely makes sense.
However, I'm not sure if it should be part of 1.7. At the end, it would be released as a patch (which gives us a high level of confidence, that some people will upgrade their apps to this version and it will change the translation of their email. Therefore, maybe we should add it to the UPGRADE.md file? Also, I would say we should keep old translation in place.
6fd3abc to
1f8264d
Compare
1f8264d to
2d16805
Compare
lchrusciel
approved these changes
Jul 14, 2020
Contributor
|
Thank you, Jacques! 🎉 |
|
Thank you. This change is needed for Japanese localization as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this discussion on Crowdin: https://crowdin.com/translate/sylius/981/en-fr#34209.
The way the sentence was handled gives a bad translation in French since we need to
change the order of the 3 elements previously involved.
Using a placeholder
%tracking_code%here will allow to have a correct translationin all languages.