[Api][Cart] change quantity on cart#11695
Merged
Merged
Conversation
Contributor
AdamKasp
commented
Jul 29, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
Tomanhez
reviewed
Jul 29, 2020
| * @var int | ||
| * @psalm-immutable | ||
| */ | ||
| public $newQuantity; |
Contributor
There was a problem hiding this comment.
Suggested change
| public $newQuantity; | |
| public $quantity; |
Should be enough
Contributor
Author
There was a problem hiding this comment.
i chose newQuantity because this name is visible in the request body, and IMO newQuantity is more descriptive than just quantity
Tomanhez
reviewed
Jul 29, 2020
78d6cdd to
bccfe0b
Compare
6809df6 to
8a17de2
Compare
GSadee
reviewed
Jul 31, 2020
6127964 to
8a0b829
Compare
GSadee
approved these changes
Jul 31, 2020
8a0b829 to
ecaf25c
Compare
Member
|
Thank you, Adam! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.