[Api][Checkout] Modify ShippingMethod and PaymentMethod paths on Checkout#11745
Merged
GSadee merged 7 commits intoSep 7, 2020
Merged
Conversation
f58ec77 to
03072b9
Compare
GSadee
reviewed
Aug 18, 2020
Contributor
|
|
lchrusciel
reviewed
Aug 18, 2020
03072b9 to
6669f37
Compare
a837755 to
c79410f
Compare
Tomanhez
commented
Aug 20, 2020
|
|
||
| namespace Sylius\Bundle\ApiBundle\Command; | ||
|
|
||
| interface CommandAwareDataTransformerInterface |
Contributor
Author
There was a problem hiding this comment.
I added new tag interface, because some DataTransformer can be executed only one in certain object, if we have, for example two DataTransformers where supportsTransformation (...) equals to us conditions, will be executed first in line .
c79410f to
f8baa28
Compare
949bedd to
45ba3a4
Compare
GSadee
approved these changes
Aug 20, 2020
lchrusciel
reviewed
Aug 28, 2020
| ); | ||
|
|
||
| $shipment = $cart->getShipments()[$shipmentIdentifier]; | ||
| $shipment = $this->getShipmentById($cart, $chooseShippingMethod->shipmentId); |
Contributor
There was a problem hiding this comment.
Instead of checking id for all shipments, we have a repository method on ShipmentRepository::findOneByOrderId. With it, we can skill foreach loop, as well, as fetching cart.
What is more, as we moved the definition of the route from cart to shipment, we should return shipment instead of cart.
|
|
||
| public function getSubresourceIdAttributeKey(): string | ||
| { | ||
| return 'shipmentId'; |
Contributor
There was a problem hiding this comment.
IMHO, the command should not be aware of path definition details. An additional interface is ok, but I would prefer to make more detailed (get/setShipmentId), make additional transformer, where shipmentId will be injected into the constructor.
Also, can you check if we can use parameters in route definition?
Contributor
Author
There was a problem hiding this comment.
I added getSubresourceIdAttributeKey instead of details like get/setShipmentId, because i would use it in next cases like payment, out of the box without duplicated boilerplate code.
f6f4f43 to
c12ff32
Compare
81983b8 to
0e6a366
Compare
Tomanhez
commented
Sep 3, 2020
b4f4b5b to
a4f0dab
Compare
GSadee
reviewed
Sep 3, 2020
e23e38d to
9f60b6f
Compare
GSadee
approved these changes
Sep 4, 2020
3002262 to
5905d78
Compare
5905d78 to
fc12d21
Compare
Member
|
Thank you, Tomasz! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Sep 9, 2020
This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Following #11745 | License | MIT I've adjusted service names to follow our conventions, removed unneeded classes, and typehinted variadic expression Commits ------- a19f1ac [API] Adjust services names to common convention 4dbf19f [API] Add variadic typehint e878b19 [API] Refactored CommandAwareInputDataTransformer
lchrusciel
added a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Sep 9, 2020
This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Following Sylius/Sylius#11745 | License | MIT I've adjusted service names to follow our conventions, removed unneeded classes, and typehinted variadic expression Commits ------- a19f1ac1a7f902e9183979fd414ef2ab3063ee96 [API] Adjust services names to common convention 4dbf19f7224992749c2ed3b14e43aba15866cd5c [API] Add variadic typehint e878b1935ac351ac0214a50060b940abd43f4a8e [API] Refactored CommandAwareInputDataTransformer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its continue: #11735