[API][Checkout] Cover scenarios for checking promotions#11749
Conversation
GSadee
commented
Aug 19, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
d0048f7 to
0f3f5f5
Compare
| public function shouldBeAppliedToMyOrder(string $promotionName): void | ||
| { | ||
| $response = $this->client->show($this->sharedStorage->get('cart_token')); | ||
| Assert::notFalse(array_search($promotionName, array_column($this->getAdjustmentsForOrder(), 'label'))); |
There was a problem hiding this comment.
This extraction logic seems like a good candidate for placing it in separate private method
| /** | ||
| * @Then :promotionName should be applied to my order shipping | ||
| */ | ||
| public function shouldBeAppliedToMyOrderShipping(string $promotionName): void |
There was a problem hiding this comment.
Can we merge it with the previous step?
| } | ||
|
|
||
| /** | ||
| * @Then /^the ("[^"]+" product) should have unit price discounted by ("\$\d+")$/ |
There was a problem hiding this comment.
Why didn't you use our price transformation here?
| { | ||
| $response = $this->client->customAction( | ||
| sprintf('/new-api/orders/%s/items/%s/adjustments', $this->sharedStorage->get('cart_token'), $itemId), | ||
| HttpRequest::METHOD_GET); |
There was a problem hiding this comment.
| HttpRequest::METHOD_GET); | |
| HttpRequest::METHOD_GET) | |
| ; |
| </itemOperations> | ||
|
|
||
| <subresourceOperations> | ||
| <subresourceOperation name="api_order_items_adjustments_get_subresource"> |
There was a problem hiding this comment.
What is the difference between these two operations?
There was a problem hiding this comment.
Using the subresources to generate adjustments endpoints, for example to have endpoint: /orders/{token}/items/{id}/adjustments, we need to expose also /order-items/{id}/adjustments.
These are all adjustments endpoints that are currently exposed:
| ->shouldReturn(false) | ||
| ; | ||
|
|
||
| $context['subresource_identifiers'] = ['id' => 'TOKEN']; |
There was a problem hiding this comment.
We should test the version with items as well
|
Thank you, Grzegorz! 🎉 |
|
|
||
| return | ||
| is_a($resourceClass, AdjustmentInterface::class, true) && | ||
| isset($subresourceIdentifiers['id']) && |
There was a problem hiding this comment.
It is possible to merge it to isset($subresourceIdentifiers['id'], $subresourceIdentifiers['items']) 🚀
This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes for review from #11749 | License | MIT Commits ------- 2b41ca9 [API] Minor fixes for adjustments