[Core] added default factory for avatar image#11751
Merged
Merged
Conversation
Contributor
foxou33
commented
Aug 19, 2020
| Q | A |
|---|---|
| Branch? | 1.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #11163 |
| License | MIT |
lchrusciel
reviewed
Aug 20, 2020
lchrusciel
reviewed
Aug 21, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Plus if I see correctly, we should implement this interface on that class itself
Contributor
|
The build should be green after merging #11780 |
lchrusciel
reviewed
Sep 1, 2020
Contributor
Author
|
I think I messed up trying to merge #11780. I'm not sure how to revert. |
555917e to
6e25522
Compare
Contributor
|
I've rebased your PR and fixed commits. All of them are still yours, of course :) Let's wait for green build and it is good to go |
lchrusciel
approved these changes
Sep 8, 2020
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
Contributor
|
Not stale. Very useful and looks ready to merge, isn't it? |
f8a54d7 to
d1e370f
Compare
Contributor
|
Thanks, @foxou33 and @lchrusciel :) |
d1e370f to
51459e8
Compare
Contributor
|
Thank you, @foxou33! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Nov 26, 2021
…on fix (lchrusciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes to #11751 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 2538e83 [Minor] Removal of additional spaces and deprecation version fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.