Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed compatibility with newer version of data collectors#11778

Merged
lchrusciel merged 1 commit into
Sylius:1.8from
stloyd:bugfix/data-collector
Sep 15, 2020
Merged

Fixed compatibility with newer version of data collectors#11778
lchrusciel merged 1 commit into
Sylius:1.8from
stloyd:bugfix/data-collector

Conversation

@stloyd
Copy link
Copy Markdown
Contributor

@stloyd stloyd commented Aug 31, 2020

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets related #10928
License MIT

Error without this change:

HP Fatal error:  Declaration of Sylius\Bundle\ChannelBundle\Collector\ChannelCollector::collect(Symfony\Component\HttpFoundation\Request $request, Symfony\Component\HttpFoundation\Response $response, ?Exception $exception = NULL): void must be compatible with Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect(Symfony\Component\HttpFoundation\Request $request, Symfony\Component\HttpFoundation\Response $response, ?Throwable $exception = NULL) in /var/www/dimedic-reports/current/vendor/sylius/sylius/src/Sylius/Bundle/ChannelBundle/Collector/ChannelCollector.php on line 61

@stloyd stloyd requested a review from a team as a code owner August 31, 2020 12:04
lchrusciel
lchrusciel approved these changes Sep 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Józef,

can you rebase to newest master? The build should be green then. BTW. We should probably mark all collectors as @internal And of course, thanks for your contribution :)

@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Sep 1, 2020

@lchrusciel But master means it's 1.9-dev not 1.8, do we want to not make 1.8 more compatible with Symfony 5?

@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Sep 1, 2020

My bad, of course to 1.8

@stloyd stloyd force-pushed the bugfix/data-collector branch from 08bc062 to c777bc5 Compare September 1, 2020 09:40
@stloyd stloyd force-pushed the bugfix/data-collector branch from c777bc5 to b413575 Compare September 7, 2020 12:54
@lchrusciel lchrusciel merged commit cd9f00a into Sylius:1.8 Sep 15, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Sep 15, 2020

Thanks, Joseph! 🥇

@stloyd stloyd deleted the bugfix/data-collector branch September 15, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee approved these changes

+1 more reviewer

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stloyd @lchrusciel @GSadee