[API][AddressBook] Setting default address#11961
Merged
GSadee merged 1 commit intoOct 26, 2020
Merged
Conversation
Contributor
AdamKasp
commented
Oct 26, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
arti0090
reviewed
Oct 26, 2020
| { | ||
| $userShowResponse = $this->customerClient->show((string) $this->sharedStorage->get('user')->getCustomer()->getId()); | ||
| Assert::null($this->responseChecker->getValue($userShowResponse, 'defaultAddress'), 'Default address should be null' | ||
| ); |
Contributor
There was a problem hiding this comment.
Can we move this ); to one line 😄 As we can see it even cries because of it
arti0090
approved these changes
Oct 26, 2020
GSadee
reviewed
Oct 26, 2020
| $this->addressClient->index(); | ||
|
|
||
| Assert::same(count($this->responseChecker->getCollection($this->client->getLastResponse())), $count); | ||
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->getLastResponse())), $count); |
Member
There was a problem hiding this comment.
Suggested change
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->getLastResponse())), $count); | |
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->index())), $count); |
| public function iShouldHaveAddresses(int $count = 1): void | ||
| { | ||
| $this->client->index(); | ||
| $this->addressClient->index(); |
Member
There was a problem hiding this comment.
Suggested change
| $this->addressClient->index(); |
Comment on lines
+183
to
+191
| $addressIri = $this->getAddressIriFromAddressBookByFullName($fullName); | ||
| $addressBook = $this->responseChecker->getCollection($this->addressClient->getLastResponse()); | ||
|
|
||
| Assert::notEmpty( | ||
| array_filter($addressBook, function($address) use ($addressIri) { | ||
| return $address['@id'] === $addressIri; | ||
| }), | ||
| sprintf('There is no Address assigned to %s', $fullName) | ||
| ); |
Member
There was a problem hiding this comment.
I wonder if this method makes sense, because in getAddressIriFromAddressBookByFullName method you are getting an address from the address book and then you are checking if this address is in the same address book 😃
Maybe you could use an address transformer to get an address by full name and then check if this address is in address book? Or even simple, just check if the value returned from getAddressIriFromAddressBookByFullName method is not null.
| public function thereShouldBeNoAddresses(): void | ||
| { | ||
| $this->client->index(); | ||
| $this->addressClient->index(); |
Member
There was a problem hiding this comment.
Suggested change
| $this->addressClient->index(); |
| $this->addressClient->index(); | ||
|
|
||
| Assert::same(count($this->responseChecker->getCollection($this->client->getLastResponse())), 0); | ||
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->getLastResponse())), 0); |
Member
There was a problem hiding this comment.
Suggested change
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->getLastResponse())), 0); | |
| Assert::same(count($this->responseChecker->getCollection($this->addressClient->index())), 0); |
| { | ||
| Assert::notNull($fullName); | ||
| $fullNameArray = explode(' ',$fullName); | ||
| [$firstName, $lastName] = explode(' ',$fullName); |
Member
There was a problem hiding this comment.
Suggested change
| [$firstName, $lastName] = explode(' ',$fullName); | |
| [$firstName, $lastName] = explode(' ', $fullName); |
| private function getAddressIriFromAddressBookByFullName(string $fullName): ?string | ||
| { | ||
| Assert::notNull($fullName); | ||
| [$firstName, $lastName] = explode(' ',$fullName); |
Member
There was a problem hiding this comment.
Suggested change
| [$firstName, $lastName] = explode(' ',$fullName); | |
| [$firstName, $lastName] = explode(' ', $fullName); |
GSadee
approved these changes
Oct 26, 2020
Member
|
Thank you, Adam! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.