[API] Explicitly define bus to all handlers#11993
Merged
Merged
Conversation
36af6b0 to
d515ddf
Compare
oallain
approved these changes
Nov 5, 2020
Contributor
oallain
left a comment
There was a problem hiding this comment.
It fix an issue from my side, thanks !
oallain
approved these changes
Nov 7, 2020
Zales0123
approved these changes
Nov 10, 2020
Contributor
|
Thanks, Łukasz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony messenger component will register handlers into all busses if we won't specify it. I would say, that additional busses are common enough, that we should not register our handlers in different busses by default.
Ref. https://symfony.com/doc/current/messenger/multiple_buses.html#restrict-handlers-per-bus