[CI] Switch packages build from Travis to GitHub Actions#12089
Merged
Conversation
lchrusciel
approved these changes
Nov 26, 2020
pamil
added a commit
that referenced
this pull request
Nov 30, 2020
…ctions (pamil) This PR was merged into the 1.8 branch. Discussion ---------- The last PR of the three-part series (#12087, #12089) - switching the application build from Travis CI to GitHub Actions. Non-JS Behat take around 20% longer (from ~10-11 minutes to ~12-14 minutes) and PHPUnit around 50% longer (from ~1.5m to ~2.5m), I've got no idea what is it caused by, but we've much better parallelization of the builds, so we should be able to get feedback much faster anyway. Commits ------- 1139d72 [CI] Switch application build from Travis to GitHub Actions
stof
reviewed
Dec 1, 2020
| if: matrix.symfony != '' | ||
| run: | | ||
| composer global require --no-progress --no-scripts --no-plugins "symfony/flex:^1.10" | ||
| composer config extra.symfony.require "${{ matrix.symfony }}" |
There was a problem hiding this comment.
shouldn't this have working-directory too, to set this extra.symfony.require config in the right composer.json ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will create two jobs for every package that we have, making use of 20 parallel jobs GitHub Actions provides.