[API] change new-api prefix to api#12257
Merged
Merged
Conversation
Contributor
SirDomin
commented
Jan 18, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | i think yes |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
reviewed
Jan 19, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
There should definitely be a proper note in the UPGRADE file about these changes
07cb5cc to
dc2a42f
Compare
GSadee
reviewed
Jan 21, 2021
dc2a42f to
2d8a257
Compare
AdamKasp
approved these changes
Jan 21, 2021
GSadee
approved these changes
Jan 21, 2021
GSadee
reviewed
Jan 21, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
Changes in config/packages should be reflected in UPGRADE file
5835d14 to
c13c7b1
Compare
c13c7b1 to
361de7b
Compare
lchrusciel
reviewed
Jan 21, 2021
b018e29 to
d2bdb35
Compare
pamil
reviewed
Jan 21, 2021
| { | ||
| "code": "NEW_MUG_CODE", | ||
| "version": $version | ||
| "version": "$version" |
Contributor
There was a problem hiding this comment.
Why is that necessary? It isn't API version.
Contributor
Author
There was a problem hiding this comment.
its failing without it for some reason :/
648bbab to
956d589
Compare
956d589 to
d02f20d
Compare
pamil
approved these changes
Jan 21, 2021
Contributor
|
Thanks, @SirDomin! 🎉 |
Tomanhez
added a commit
to Sylius/SyliusDemo
that referenced
this pull request
Jan 22, 2021
…2 (GSadee) This PR was merged into the 1.0-dev branch. Discussion ---------- After Sylius/Sylius#12257 Commits ------- cb1009c [Maintenance] Adjust configs after change new-api to api/v2
lchrusciel
added a commit
that referenced
this pull request
Feb 5, 2021
…lchrusciel) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #12257 | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 2b0d76d [API] move security parameters to bundles a547a3b upgrade UPGRADE.md file 0b7d6af [UPGRADE] Add more precise upgrade note
billybrona
pushed a commit
to billybrona/SyliusDemo
that referenced
this pull request
Nov 26, 2023
…2 (GSadee) This PR was merged into the 1.0-dev branch. Discussion ---------- After Sylius/Sylius#12257 Commits ------- cb1009cd2ae245b4bbf03d3b7e3dfb4b42d4674c [Maintenance] Adjust configs after change new-api to api/v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.