[API] Password reset#12360
Merged
Merged
Conversation
Contributor
arti0090
commented
Feb 17, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
GSadee
reviewed
Feb 17, 2021
10e13e8 to
6d453ce
Compare
e8dbb38 to
ecadef4
Compare
Contributor
Author
|
TODO for part 2:
|
arti0090
commented
Feb 18, 2021
arti0090
commented
Feb 18, 2021
dc43d89 to
21d724c
Compare
21d724c to
656719d
Compare
Tomanhez
reviewed
Feb 18, 2021
lchrusciel
reviewed
Feb 18, 2021
GSadee
reviewed
Feb 19, 2021
249185e to
5bc148c
Compare
AdamKasp
suggested changes
Feb 19, 2021
lchrusciel
reviewed
Feb 24, 2021
AdamKasp
approved these changes
Feb 24, 2021
7dd3ed4 to
e79526a
Compare
Tomanhez
reviewed
Feb 24, 2021
GSadee
reviewed
Feb 25, 2021
cddf339 to
68049ef
Compare
68049ef to
53e2976
Compare
lchrusciel
approved these changes
Feb 25, 2021
| <collectionOperation name="shop_password_reset_request"> | ||
| <attribute name="method">POST</attribute> | ||
| <attribute name="path">shop/request-reset-password</attribute> | ||
| <attribute name="messenger">input</attribute> |
Contributor
There was a problem hiding this comment.
Could go to the generic section (below validation_groups)
Comment on lines
+28
to
+29
| <attribute name="output">false</attribute> | ||
| <attribute name="status">202</attribute> |
Contributor
There was a problem hiding this comment.
Maybe could go to the generic section (below validation_groups)
| <attribute name="status">202</attribute> | ||
| <attribute name="validation_groups"> | ||
| <attribute>sylius</attribute> | ||
| <attribute>sylius_shop_password_reset</attribute> |
Contributor
|
Thank you, @arti0090! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.