Drop sspooky13/yaml-standards ^5.1 in favour of ^6.0#12457
Merged
Conversation
Zales0123
approved these changes
Mar 23, 2021
Contributor
|
Thank you, Kamil! 🥇 |
pamil
added a commit
that referenced
this pull request
Apr 7, 2021
This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Hello, I am glad you upgrade dependency to [yaml-standards](https://github.com/sspooky13/yaml-standards) but you changed [only version number](#12457) and you didn't change logic to find files 😅, now you [need to use wildcard to find files](https://github.com/sspooky13/yaml-standards/blame/master/CHANGELOG.md#L11). I take this as feedback that changelog is not written well. I will be glad for every help how to write it better or what should I do to make sure this doesn't happen again? 🤔 Thank you in advance 🤝 Commits ------- 0b25945 fixed find files in yaml standards
lchrusciel
pushed a commit
to Sylius/SyliusAdminBundle
that referenced
this pull request
Apr 9, 2021
This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Hello, I am glad you upgrade dependency to [yaml-standards](https://github.com/sspooky13/yaml-standards) but you changed [only version number](Sylius/Sylius#12457) and you didn't change logic to find files 😅, now you [need to use wildcard to find files](https://github.com/sspooky13/yaml-standards/blame/master/CHANGELOG.md#L11). I take this as feedback that changelog is not written well. I will be glad for every help how to write it better or what should I do to make sure this doesn't happen again? 🤔 Thank you in advance 🤝 Commits ------- 0b2594590eae65426af4f51228832e5dcb2bcf71 fixed find files in yaml standards
lchrusciel
pushed a commit
to Sylius/SyliusCoreBundle
that referenced
this pull request
Apr 9, 2021
This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Hello, I am glad you upgrade dependency to [yaml-standards](https://github.com/sspooky13/yaml-standards) but you changed [only version number](Sylius/Sylius#12457) and you didn't change logic to find files 😅, now you [need to use wildcard to find files](https://github.com/sspooky13/yaml-standards/blame/master/CHANGELOG.md#L11). I take this as feedback that changelog is not written well. I will be glad for every help how to write it better or what should I do to make sure this doesn't happen again? 🤔 Thank you in advance 🤝 Commits ------- 0b2594590eae65426af4f51228832e5dcb2bcf71 fixed find files in yaml standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version ^6.0 is enough and installable with lowest supported dependencies.