[API] Resend Verification email#12474
Merged
Merged
Conversation
Contributor
arti0090
commented
Mar 23, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
8afef57 to
99a6f21
Compare
AdamKasp
approved these changes
Mar 23, 2021
99a6f21 to
ab9bda4
Compare
GSadee
reviewed
Mar 24, 2021
GSadee
approved these changes
Mar 24, 2021
Member
|
Thank you, @arti0090! 🎉 |
lchrusciel
reviewed
Mar 24, 2021
Comment on lines
+63
to
+67
| if (!$channel->isAccountVerificationRequired()) { | ||
| $user->setEnabled(true); | ||
|
|
||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Where did this logic come from? Do we have a scenario for this case?
GSadee
added a commit
that referenced
this pull request
Mar 24, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #12474 (comment) | License | MIT Commits ------- 3b0f3c3 Remove unnecessary logic from handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.