[Api] Product has last 3 reviews by default#12483
Merged
Merged
Conversation
Contributor
SirDomin
commented
Mar 26, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
8fefe1a to
47965c3
Compare
arti0090
reviewed
Mar 26, 2021
47965c3 to
5f0ce40
Compare
AdamKasp
suggested changes
Mar 26, 2021
lchrusciel
reviewed
Mar 26, 2021
| <attribute name="createdAt"> | ||
| <group>product_review:read</group> | ||
| </attribute> | ||
| <group>product_review:read</group> |
Contributor
There was a problem hiding this comment.
As you've touched this place anyway, can we adjust previous serialization groups to admin:product_review:read? Can be done in separate PR
GSadee
reviewed
Mar 26, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
There is also a need for adding a filter with sorting product reviews
AdamKasp
reviewed
Mar 29, 2021
1fa4671 to
21b91f5
Compare
AdamKasp
approved these changes
Mar 29, 2021
arti0090
approved these changes
Mar 29, 2021
GSadee
reviewed
Mar 29, 2021
21b91f5 to
8e74ab7
Compare
d71210c to
849ca13
Compare
GSadee
approved these changes
Mar 30, 2021
Member
|
Thank you, @SirDomin! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.