[API] Add admin and shop section resolvers#12509
Merged
Merged
Conversation
Member
GSadee
commented
Apr 6, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
b06937d to
fcd1075
Compare
lchrusciel
approved these changes
Apr 6, 2021
fcd1075 to
0d8c3ea
Compare
Zales0123
approved these changes
Apr 7, 2021
| use Sylius\Bundle\CoreBundle\SectionResolver\SectionInterface; | ||
| use Sylius\Bundle\CoreBundle\SectionResolver\UriBasedSectionResolverInterface; | ||
|
|
||
| final class AdminApiUriBasedSectionResolver implements UriBasedSectionResolverInterface |
Contributor
There was a problem hiding this comment.
Just a rough idea - these UriBasedSectionsResolvers have generally the same implementation, it only differs regarding the returned class (still, the interface is the same). Maybe it would be worth extracting some generic resolver from them? 🤔 Not a block for merge, just thinking out loud 🖖
0d8c3ea to
b02b49c
Compare
lchrusciel
approved these changes
Apr 9, 2021
|
|
||
| use Sylius\Bundle\CoreBundle\SectionResolver\SectionInterface; | ||
|
|
||
| class AdminApiSection implements SectionInterface |
Contributor
There was a problem hiding this comment.
I'm not sure if it is not misleading in comparison to old AdminAPI
Member
Author
There was a problem hiding this comment.
I thought about that, but it is still the most significant name and it is in different bundle, so I think it is the best name after all.
Contributor
|
Thank you, Grzegorz! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Apr 13, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on #12509 Commits ------- 6a525e7 Remove listening for JWT event in CartBlamerListener and use section provider in this listener 87e13c5 [API] Overwrite CartBlamerListener in ApiBundle 34c8357 add new Section class and fix cart blaming 7aaf9d3 move cartBlamerListener to proper bundle 9fd8d13 fix and rename listeners
GSadee
pushed a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Apr 15, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on Sylius/Sylius#12509 Commits ------- 6a525e7d885f1539ee8494b2518f0fa11ca21d21 Remove listening for JWT event in CartBlamerListener and use section provider in this listener 87e13c5088fb1128d06b4760dce422d122e7819d [API] Overwrite CartBlamerListener in ApiBundle 34c83578327701925e49800b481a6554e4f2164d add new Section class and fix cart blaming 7aaf9d34ac683e8a3e0e8dfa224e416c9047c6d5 move cartBlamerListener to proper bundle 9fd8d132939b50d7f744ee49e7e7f94107a3f84c fix and rename listeners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.