Codestin Search App

arti0090 · 2021-08-23T09:40:31Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
License	MIT

extends #12986

GSadee

IMO, in this PR you should add also behat scenarios for updating and deleting catalog promotion

arti0090 · 2021-08-24T12:32:54Z

Behat tests for this feature will be added in next PR 🎉

lchrusciel · 2021-08-24T13:58:55Z

+                <attribute name="normalization_context">
+                    <attribute name="groups">admin:catalog_promotion:update</attribute>
+                </attribute>


Suggested change

<attribute name="normalization_context">

<attribute name="groups">admin:catalog_promotion:update</attribute>

</attribute>

<attribute name="normalization_context">

<attribute name="groups">admin:catalog_promotion:read</attribute>

</attribute>

GSadee · 2021-08-25T05:02:39Z

            <collectionOperation name="admin_post">
                <attribute name="method">POST</attribute>
+                <attribute name="normalization_context">
+                    <attribute name="groups">admin:catalog_promotion:create</attribute>


Suggested change

<attribute name="groups">admin:catalog_promotion:create</attribute>

<attribute name="groups">admin:catalog_promotion:read</attribute>

GSadee · 2021-08-25T05:03:43Z

+
+        $response = $this->client->getResponse();
+
+        $this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotions_admin_response', Response::HTTP_OK);


Suggested change

$this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotions_admin_response', Response::HTTP_OK);

$this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotions_response', Response::HTTP_OK);

GSadee · 2021-08-25T05:03:54Z

        $response = $this->client->getResponse();

-        $this->assertResponse($response, 'admin/get_catalog_promotions_response', Response::HTTP_OK);
+        $this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotion_admin_response', Response::HTTP_OK);


Suggested change

$this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotion_admin_response', Response::HTTP_OK);

$this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotion_response', Response::HTTP_OK);

GSadee · 2021-08-25T05:04:14Z

+
+        $response = $this->client->getResponse();
+
+        $this->assertResponse($response, 'admin/catalog_promotion/post_catalog_promotion_admin_response', Response::HTTP_CREATED);


Suggested change

$this->assertResponse($response, 'admin/catalog_promotion/post_catalog_promotion_admin_response', Response::HTTP_CREATED);

$this->assertResponse($response, 'admin/catalog_promotion/post_catalog_promotion_response', Response::HTTP_CREATED);

GSadee · 2021-08-25T05:04:25Z

+
+        $response = $this->client->getResponse();
+
+        $this->assertResponse($response, 'admin/catalog_promotion/put_catalog_promotion_admin_response', Response::HTTP_OK);


Suggested change

$this->assertResponse($response, 'admin/catalog_promotion/put_catalog_promotion_admin_response', Response::HTTP_OK);

$this->assertResponse($response, 'admin/catalog_promotion/put_catalog_promotion_response', Response::HTTP_OK);

GSadee · 2021-08-25T05:04:51Z

+        $token = $this->logInAdminUser('[email protected]');
+        $authorizationHeader = self::$container->getParameter('sylius.api.authorization_header');
+        $header['HTTP_' . $authorizationHeader] = 'Bearer ' . $token;
+        return array_merge($header, self::CONTENT_TYPE_HEADER);


Suggested change

return array_merge($header, self::CONTENT_TYPE_HEADER);

return array_merge($header, self::CONTENT_TYPE_HEADER);

GSadee · 2021-08-25T05:05:37Z

            "@id": "\/api\/v2\/admin\/catalog-promotions\/mugs_discount",
            "@type": "CatalogPromotion",
-            "id": @integer@,
+            "id": "@integer@",


Why did you change that? IMO here and in other responses there should be:

Suggested change

"id": "@integer@",

"id": @integer@,

GSadee · 2021-08-25T05:07:03Z

Thank you, @arti0090! 🥇

This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT minor fixes of #12994 Commits ------- 54328e9 Fixes to endpoints and contract tests of CP

… (arti0090) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes (behat for feature) | BC breaks? | no | Deprecations? | no | License | MIT Promised behats for #12994 Commits ------- 3e37138 Add delete behat with factory c690e3b Delete covered in behat be54912 Edit covered in behats 4e67186 Revert behat of delete 2912c4f Changing services and tests

arti0090 requested a review from a team as a code owner August 23, 2021 09:40

probot-autolabeler Bot added the API APIs related issues and PRs. label Aug 23, 2021

arti0090 changed the title ~~Update and delete catalog promotions~~ [WIP] Get, Update and delete catalog promotions Aug 23, 2021

GET, PUT, DELETE for Catalog Promotions

3fafeca

arti0090 force-pushed the update-and-delete-catalog-promotions branch from dbf1c91 to 80231af Compare August 24, 2021 07:27

POST and item GET

8186723

arti0090 force-pushed the update-and-delete-catalog-promotions branch from 80231af to 8186723 Compare August 24, 2021 07:28

GSadee mentioned this pull request Aug 24, 2021

[CatalogPromotion] Creating simple catalog promotion only with code and name #12986

Merged

GSadee reviewed Aug 24, 2021

View reviewed changes

Comment thread tests/Api/Admin/CatalogPromotionsTest.php Outdated

Comment thread tests/Api/Admin/CatalogPromotionsTest.php Outdated

Comment thread tests/Api/Admin/CatalogPromotionsTest.php Outdated

Make tests green

089e60a

arti0090 force-pushed the update-and-delete-catalog-promotions branch from 524246b to 089e60a Compare August 24, 2021 11:50

Move catalog promotion response to new dir

36bd417

arti0090 force-pushed the update-and-delete-catalog-promotions branch from b8062d5 to 5128035 Compare August 24, 2021 12:15

arti0090 changed the title ~~[WIP] Get, Update and delete catalog promotions~~ Get, Update and delete catalog promotions Aug 24, 2021

arti0090 changed the title ~~Get, Update and delete catalog promotions~~ Get, Update, Post and delete catalog promotions Aug 24, 2021

Merge branch 'master' into update-and-delete-catalog-promotions

9044d8f

arti0090 force-pushed the update-and-delete-catalog-promotions branch from 5128035 to 9044d8f Compare August 24, 2021 12:30

AdamKasp approved these changes Aug 24, 2021

View reviewed changes

lchrusciel reviewed Aug 24, 2021

View reviewed changes

GSadee approved these changes Aug 25, 2021

View reviewed changes

GSadee merged commit cb9c140 into Sylius:master Aug 25, 2021

arti0090 mentioned this pull request Aug 25, 2021

Fixes to endpoints and contract tests of CP #13003

Merged

arti0090 mentioned this pull request Aug 26, 2021

[Catalog Promotions] Add behat scenarios for endpoints #13008

Merged

	<attribute name="groups">admin:catalog_promotion:create</attribute>
	<attribute name="groups">admin:catalog_promotion:read</attribute>


		$response = $this->client->getResponse();

		$this->assertResponse($response, 'admin/catalog_promotion/get_catalog_promotions_admin_response', Response::HTTP_OK);

	return array_merge($header, self::CONTENT_TYPE_HEADER);

	return array_merge($header, self::CONTENT_TYPE_HEADER);

Uh oh!

Conversation

arti0090 commented Aug 23, 2021

Uh oh!

GSadee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arti0090 commented Aug 24, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GSadee commented Aug 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants