[Catalog Promotions] add rule to catalog promotion#13001
Merged
Zales0123 merged 20 commits intoAug 30, 2021
Conversation
Contributor
AdamKasp
commented
Aug 24, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
Arminek
reviewed
Aug 24, 2021
474ca57 to
7df15ef
Compare
arti0090
reviewed
Aug 26, 2021
Comment on lines
+23
to
+24
| <attribute name="input">Sylius\Component\Promotion\DTO\CatalogPromotion</attribute> | ||
|
|
Contributor
There was a problem hiding this comment.
Should it be added here also? Or only in post? ( just asking )
Contributor
Author
There was a problem hiding this comment.
no, it is unnecessary :)
Comment on lines
+19
to
+25
| protected $id; | ||
|
|
||
| protected ?string $type; | ||
|
|
||
| protected array $configuration = []; | ||
|
|
||
| protected ?CatalogPromotionInterface $catalogPromotion; |
Contributor
There was a problem hiding this comment.
Similar with DTO i think there should not be empty lines🤔
Contributor
Author
There was a problem hiding this comment.
I am not sure :D for my personal preferences, it looks more readable with extra spaces.
7df15ef to
f1e9661
Compare
f1e9661 to
4534b2e
Compare
GSadee
reviewed
Aug 26, 2021
4534b2e to
55b813d
Compare
Zales0123
reviewed
Aug 26, 2021
1cbf0a9 to
b001ade
Compare
Zales0123
reviewed
Aug 26, 2021
a5ffdf0 to
4d79a9f
Compare
GSadee
reviewed
Aug 27, 2021
lchrusciel
reviewed
Aug 27, 2021
Contributor
|
There is one more thing - the configuration of rules is not directly related to the entities. I don't see the benefit that would justify the necessity of custom persisters and normalizers to convert IRIs into codes. We don't have to remove this part in this PR - but I would suggest it next time we touch rule and/or action functionality. |
Arminek
approved these changes
Aug 30, 2021
3dc5064 to
19378c0
Compare
19378c0 to
2cd687d
Compare
Zales0123
reviewed
Aug 30, 2021
| } | ||
|
|
||
| /** | ||
| * @Then it should have "contains variants" rule |
Contributor
There was a problem hiding this comment.
This step is not needed anymore
| ); | ||
| } | ||
|
|
||
| private function catalogPromotionAppliesOn(ProductVariantInterface ...$productVariants): bool |
Contributor
There was a problem hiding this comment.
isCatalogPromotionAppliedOn?
| */ | ||
| public function itWillBeAppliedOnVariant(CatalogPromotionInterface $catalogPromotion, ProductVariantInterface $variant): void | ||
| { | ||
| $catalogPromotionRule = new CatalogPromotionRule(); |
Contributor
There was a problem hiding this comment.
We should use a CatalogPromotion factory here
| { | ||
| $catalogPromotionRule = new CatalogPromotionRule(); | ||
|
|
||
| $catalogPromotionRule->setType(CatalogPromotionRule::TYPE_CONTAINS_VARIANTS); |
Contributor
There was a problem hiding this comment.
Maybe it's also a good idea to introduce per-type create methods? Like createContainsVariant(array $configuration)? But it can be an improvement
| ] | ||
| ] | ||
| ] | ||
| ); |
Contributor
There was a problem hiding this comment.
What if we make the return array a one-liner?
$normalizer
->normalize($catalogPromotion, null, ['sylius_catalog_promotion_normalizer_already_called' => true])
->willReturn(['rules' => [['configuration' => ['MUG', 'MUG_2']]]])
;still readable and takes a few lines less 💃
Zales0123
approved these changes
Aug 30, 2021
Contributor
|
Thank you, Adam and Dominik! 🎉 |
GSadee
reviewed
Aug 30, 2021
|
|
||
| interface CatalogPromotionRuleInterface extends ResourceInterface | ||
| { | ||
| public const TYPE_CONTAINS_VARIANTS = 'contains_variants'; |
Member
There was a problem hiding this comment.
IMO this const should be defined in Core as Promotion component has no dependency to Product bundle/component
GSadee
added a commit
that referenced
this pull request
Aug 31, 2021
…pplication (Zales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | | Related tickets | based on #13001 | License | MIT Commits ------- fead5a9 Use rules in catalog promotion application 80dfb73 Adjust and implement Behat scenarios 51a7109 Include CatalogPromotionRule in doctrine listener a1378c9 Fix adding CP rule to CP in Behat 28e9cb6 Apply CP on variant and change the rule name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.