Catalog promotions action#13029
Merged
Merged
Conversation
Contributor
SirDomin
commented
Aug 30, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
AdamKasp
reviewed
Aug 30, 2021
GSadee
reviewed
Aug 31, 2021
loevgaard
reviewed
Aug 31, 2021
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->scalarNode('model')->defaultValue(CatalogPromotionAction::class)->cannotBeEmpty()->end() | ||
| ->scalarNode('interface')->defaultValue(CatalogPromotionActionInterface::class)->cannotBeEmpty()->end() |
Contributor
There was a problem hiding this comment.
Isn't needed anymore
Suggested change
| ->scalarNode('interface')->defaultValue(CatalogPromotionActionInterface::class)->cannotBeEmpty()->end() |
Contributor
There was a problem hiding this comment.
Indeed 👍 but to be consistent with other configurations I would leave it for now and remove altogether later 🖖
GSadee
reviewed
Aug 31, 2021
lchrusciel
reviewed
Aug 31, 2021
Arminek
approved these changes
Aug 31, 2021
8a348bd to
9a1c189
Compare
763187c to
c7af95f
Compare
GSadee
approved these changes
Sep 1, 2021
|
|
||
| interface CatalogPromotionInterface extends BaseCatalogPromotionInterface, ChannelsAwareInterface | ||
| { | ||
| public const TYPE_CONTAINS_VARIANTS = 'contains_variants'; |
Member
There was a problem hiding this comment.
This type should be on CatalogPromotionRuleInterface in Core, and it has been already changed to for_variants
Member
|
Thanks, @SirDomin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Sep 1, 2021
…on (Zales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | based on #13029 | License | MIT Commits ------- 7a01498 Use CatalogPromotion actions for discounts application d0afff7 PR review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.