Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Maintenance] Prepend Doctrine configuration for smoother update to v3#13283

Closed
stloyd wants to merge 1 commit into
Sylius:1.9from
stloyd:patch-6
Closed

[Maintenance] Prepend Doctrine configuration for smoother update to v3#13283
stloyd wants to merge 1 commit into
Sylius:1.9from
stloyd:patch-6

Conversation

@stloyd
Copy link
Copy Markdown
Contributor

@stloyd stloyd commented Nov 9, 2021

Q A
Branch? 1.9
Bug fix? yes*
New feature? no
BC breaks? no
Deprecations? no
Related tickets alternative to #13252 & #13275
License MIT

This is alternative approach to register json_array for BC instead of forcing conflict with Doctrine v3

@stloyd stloyd requested a review from a team as a code owner November 9, 2021 17:03
@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Nov 9, 2021

@lchrusciel @Zales0123 What do you think? (I didn't remove composer.json conflict yet, but wanted to get feedback on code change).

@lchrusciel
Copy link
Copy Markdown
Contributor

As json and json_array types are almost idiomatic, I would recommend change of the field types instead of aliases

@jakubtobiasz
Copy link
Copy Markdown
Contributor

Hi @stloyd!
Thanks for your effort, the issue seems to be resolved in the supported versions of Sylius 💃🏻.

@stloyd stloyd deleted the patch-6 branch February 3, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants