[CatalogPromotion][API][UI] Fixed discount action#13325
Merged
Zales0123 merged 11 commits intoNov 26, 2021
Conversation
Member
GSadee
commented
Nov 24, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
AdamKasp
approved these changes
Nov 24, 2021
835dbf6 to
3478fe3
Compare
lchrusciel
reviewed
Nov 24, 2021
|
|
||
| /** @var CatalogPromotionActionInterface $value */ | ||
| if ($value->getType() !== CatalogPromotionActionInterface::TYPE_PERCENTAGE_DISCOUNT) { | ||
| if (!in_array($value->getType(), $this->actionTypes, true)) { |
Contributor
There was a problem hiding this comment.
It appears that taking into account this snippet:
one may add custom validator for a new action type, yet won't be able to use it, because they would need to override this service definition as we are hardcoded for two choices anyway
Member
Author
There was a problem hiding this comment.
That's true, it looks the same with validators for scopes. What is your suggestion? The simplest one is probably to have a separate parameter that is an array of these types 🤔
Contributor
There was a problem hiding this comment.
The parameter would be a good improvement. However, going deeper what would you say, that these consts would be defined by calculators themselves? Then we could tag them and use their const as a tag attribute and here use another tag iterator. Going further, we could define expectations for static method with the name, but I'm not sure if it makes sense to introduce it day before the end of sprint
ref. https://symfony.com/doc/current/service_container/tags.html#tagged-services-with-index
Member
Author
There was a problem hiding this comment.
I'm 👌🏻 for refactoring, but I would be for making it in a separate PR for both actions and scopes
fcd8898 to
50c9270
Compare
…new fixed discount action
…ew fixed discount action
ea5c411 to
f056098
Compare
SirDomin
approved these changes
Nov 25, 2021
f056098 to
969595a
Compare
Zales0123
approved these changes
Nov 26, 2021
Contributor
|
Thanks, Grzegorz! 🥇 |
This was referenced Dec 15, 2021
AdamKasp
added a commit
that referenced
this pull request
Dec 16, 2021
…tion on catalog show page (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13325 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 98c7cd3 [CatalogPromotion][Admin] Fix displaying fixed discount action on catalog show page
AdamKasp
added a commit
that referenced
this pull request
Dec 16, 2021
…reating a custom action + minor improvements (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially fixes ##13325 (comment) | License | MIT This PR contains a minor refactor of parameters with types of actions/scopes passed to validators. <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 7f33db6 [CatalogPromotion] Create parameters with collections of scopes and actions types 08e9a0c [Documentation][CatalogPromotion] Add cookbook about creating a custom action c4816cd [Documentation][CatalogPromotion] Minor improvements to cookbook about creating a custom scope e45593d [Documentation][CatalogPromotion] Fixes to cookbooks about creating custom action and scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.