[Migrations] Remove invalid NOT NULL usage#13388
Merged
Merged
Conversation
9724704 to
3cc570e
Compare
c126ba3 to
3cc570e
Compare
3cc570e to
78149d9
Compare
AdamKasp
approved these changes
Dec 14, 2021
Contributor
|
Thank you, Mateusz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I see, this
NOT NULLis not needed at all when the default value is0. Additionally, when changing from Sylius 1.10 todev-master(or rather - upcoming 1.11), it results in exception while migrations are applied: