[Translations][Shop][API] Dynamic serialization of translations for a Product, ProductVariant and Taxon entities#13401
Merged
GSadee merged 1 commit intoDec 17, 2021
Merged
Conversation
Contributor
Rafikooo
commented
Dec 16, 2021
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
… Product, ProductVariant and Taxon entities
Rafikooo
commented
Dec 16, 2021
GSadee
approved these changes
Dec 17, 2021
| int $quantity, | ||
| string $customerOrAdmin | ||
| ): void { | ||
| if (!($customerOrAdmin === 'customer' || $customerOrAdmin === 'admin')) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!($customerOrAdmin === 'customer' || $customerOrAdmin === 'admin')) { | |
| if ($customerOrAdmin !== 'customer' && $customerOrAdmin !== 'admin') { |
|
|
||
| <property name="id" identifier="false" writable="false" /> | ||
| <property name="code" identifier="true" required="true" /> | ||
| <property name="name" identifier="false" required="true" /> |
Member
There was a problem hiding this comment.
Suggested change
| <property name="name" identifier="false" required="true" /> | |
| <property name="name" required="true" /> |
I guess it is not needed
Comment on lines
+64
to
+65
| <property name="name" identifier="false" required="true" /> | ||
| <property name="description" identifier="false" required="true" /> |
Member
There was a problem hiding this comment.
Suggested change
| <property name="name" identifier="false" required="true" /> | |
| <property name="description" identifier="false" required="true" /> | |
| <property name="name" required="true" /> | |
| <property name="description" required="true" /> |
Member
|
Thank you, Rafał! 🥇 |
lchrusciel
reviewed
Dec 17, 2021
Comment on lines
+44
to
+46
| /** | ||
| * @test | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @test | |
| */ | |
| /** @test */ |
| $this->checkProductQuantity($cartResponse, $productName, $quantity, 'customer'); | ||
| } | ||
|
|
||
| private function checkProductQuantity( |
Contributor
There was a problem hiding this comment.
Personally, I'm not a fan of this solution. In order to reduce duplication, we've introduced 4 if statements
Contributor
Author
There was a problem hiding this comment.
Honestly, I don't understand what exactly you mean. Could you describe in other words what I should change?
lchrusciel
reviewed
Dec 21, 2021
Comment on lines
-12
to
+13
| "translations": { | ||
| "de_DE": { | ||
| "@id": "\/api\/v2\/shop\/taxon-translations\/@integer@", | ||
| "@type": "TaxonTranslation", | ||
| "id": "@integer@", | ||
| "name": "Tassen", | ||
| "slug": "tassen", | ||
| "description": "Einige Beschreibung Lorem ipsum dolor sit amet." | ||
| }, | ||
| "en_US": { | ||
| "@id": "\/api\/v2\/shop\/taxon-translations\/@integer@", | ||
| "@type": "TaxonTranslation", | ||
| "id": "@integer@", | ||
| "name": "Mugs", | ||
| "slug": "categories\/mugs", | ||
| "description": "Some description Lorem ipsum dolor sit amet." | ||
| } | ||
| } | ||
| "name": "Mugs", | ||
| "description": "Some description Lorem ipsum dolor sit amet." |
Contributor
There was a problem hiding this comment.
Lets add slug to the response (or did you had reason not to?). Also, please mention about this change in UPGRADE-API-1.11.md
| "createdAt": @date@, | ||
| "updatedAt": @date@, | ||
| "description": "This is a mug", | ||
| "shortDescription": "Short mug description", |
Contributor
There was a problem hiding this comment.
can you add slug here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.