Missing validation added for FixedDiscountActionType#13478
Closed
TheMilek wants to merge 1 commit into
Closed
Conversation
lchrusciel
added a commit
that referenced
this pull request
Jan 13, 2022
…gurationType (TheMilek) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> We want to unify validation on both FixedDiscountActionConfigurationType and PercentageDiscountActionConfigurationType and we have to choose beetween deletion additional validation or staying with additional validation on both Close this PR in case [THIS](#13478) PR is merged Commits ------- 33a9b4f validation deleted from PercentageActionCongfigurationType
Contributor
|
Closing in favour of #13477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to unify validation on both FixedDiscountActionConfigurationType and PercentageDiscountActionConfigurationType
and we have to choose beetween deletion additional validation or staying with additional validation on both
Close this PR in case THIS PR is merged