[Maintenance] Replace test-package.sh with native GH Actions#13515
Merged
Conversation
Contributor
lchrusciel
commented
Jan 19, 2022
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
…should be triggered
loic425
approved these changes
Jan 19, 2022
8581236 to
14ff02e
Compare
vvasiloi
suggested changes
Jan 21, 2022
vvasiloi
reviewed
Jan 21, 2022
009e84c to
c845c4b
Compare
66d19f5 to
b8fb089
Compare
vvasiloi
approved these changes
Jan 21, 2022
Zales0123
approved these changes
Jan 24, 2022
| - | ||
| name: Test package | ||
| run: bin/test-package src/Sylius/${{ matrix.package }} | ||
| name: Setup Database(for ApiBundle only) |
Contributor
There was a problem hiding this comment.
Missing space before ( 😄 💃
GSadee
approved these changes
Jan 24, 2022
Comment on lines
+115
to
+116
| name: Check the existance of phpunit.xml.dist | ||
| id: phpunit_xml_dist_existance_check |
Member
There was a problem hiding this comment.
Suggested change
| name: Check the existance of phpunit.xml.dist | |
| id: phpunit_xml_dist_existance_check | |
| name: Check the existence of phpunit.xml.dist | |
| id: phpunit_xml_dist_existence_check |
Comment on lines
+122
to
+123
| name: Check the existance of phpunit.xml | ||
| id: phpunit_xml_existance_check |
Member
There was a problem hiding this comment.
Suggested change
| name: Check the existance of phpunit.xml | |
| id: phpunit_xml_existance_check | |
| name: Check the existence of phpunit.xml | |
| id: phpunit_xml_existence_check |
| - | ||
| name: Run PHPUnit | ||
| working-directory: "src/Sylius/${{ matrix.package }}" | ||
| if: steps.phpunit_xml_dist_existance_check.outputs.files_exists == 'true' || steps.phpunit_xml_existance_check.outputs.files_exists == 'true' |
Member
There was a problem hiding this comment.
Suggested change
| if: steps.phpunit_xml_dist_existance_check.outputs.files_exists == 'true' || steps.phpunit_xml_existance_check.outputs.files_exists == 'true' | |
| if: steps.phpunit_xml_dist_existence_check.outputs.files_exists == 'true' || steps.phpunit_xml_existence_check.outputs.files_exists == 'true' |
Member
|
Thanks, Łukasz! 🎉 |
GSadee
added a commit
that referenced
this pull request
Jan 24, 2022
…s0123) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | leftovers after #13515 | License | MIT Commits ------- 8faad62 [Build fix] Remove unneeded test package binary step
GSadee
added a commit
that referenced
this pull request
Jan 24, 2022
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Comments from #13515 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- fdf2d4b [Minor] Typo fixes in github packages config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.