Fix "jumping" taxons while moving up or down#15272
Conversation
Bunnyshell Preview Environment deletedAvailable commands:
|
SzymonFilipek
left a comment
There was a problem hiding this comment.
Changes passed QA check
|
Thanks for the fixes, @jakubtobiasz :) |
|
Hi guys, |
|
Hi @ehibes 👋🏼, |
|
Thanks for leaving the review @igormukhingmailcom 😅 |
There was a problem hiding this comment.
Is it necessary in presence of getOneOrNullResult? Which will throw exception like so
if (count($result) > 1) {
throw new NonUniqueResultException();
}There was a problem hiding this comment.
I wanted to eliminate a need to handle the exception.
There was a problem hiding this comment.
I wanted to eliminate a need to handle the exception.
diimpp
left a comment
There was a problem hiding this comment.
New repository methods are unused anywhere in the codebase
|
Is this works? It just doing the same |
|
@igormukhingmailcom |
| When I want to see all taxons in store | ||
| And I move up "T-Shirts" taxon | ||
| Then I should see 4 taxons on the list | ||
| And the first taxon on the list should be "T-Shirts" |
There was a problem hiding this comment.
| And the first taxon on the list should be "T-Shirts" | |
| And the first taxon on the list should still be "T-Shirts" |
This would describe the behaviour even better, the same in the below scenario
|
Thank you, Jacob! 🥇 |
Basing on #11905 I removed the "feature" part, to merge the "bug-fixing" part into
1.12. We'll consider later adding "Move top" and "Move end" features, but probably it'll be considered in terms of2.0with the new Admin Panel.Thanks @igormukhingmailcom for your work! I'm happy we're finally going to merge your commits :).
Previously:
Now:
