Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate product's channel eligibility when finalizing an order#18445

Merged
Rafikooo merged 1 commit into
Sylius:1.14from
tomkalon:bugfix/order-validation
Nov 25, 2025
Merged

Validate product's channel eligibility when finalizing an order#18445
Rafikooo merged 1 commit into
Sylius:1.14from
tomkalon:bugfix/order-validation

Conversation

@tomkalon
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.14
Bug fix? yes
New feature? no
BC breaks? no
Related tickets #17568
License MIT

When finalizing an order, while checking whether products and variants are "isEnabled," a check has also been added to see if they are assigned to the current channel.

@tomkalon tomkalon requested a review from a team as a code owner October 17, 2025 10:49
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Oct 17, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 17, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@tomkalon tomkalon changed the title Bugfix/order validation [fix] Validate product's channel eligibility in order eligibility validator Oct 17, 2025
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Oct 17, 2025
@tomkalon tomkalon force-pushed the bugfix/order-validation branch 5 times, most recently from 6794ecb to b6dd496 Compare October 17, 2025 11:49
Comment thread src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml Outdated
@tomkalon tomkalon force-pushed the bugfix/order-validation branch 6 times, most recently from 55eaf92 to c0351b5 Compare October 27, 2025 13:26
@tomkalon tomkalon force-pushed the bugfix/order-validation branch from dc15797 to 3f91026 Compare October 30, 2025 12:40
@Rafikooo Rafikooo force-pushed the bugfix/order-validation branch from 3f91026 to e367968 Compare November 24, 2025 15:03
@Rafikooo Rafikooo force-pushed the bugfix/order-validation branch from e367968 to a062a25 Compare November 24, 2025 16:40
@Rafikooo Rafikooo changed the title [fix] Validate product's channel eligibility in order eligibility validator Validate product's channel eligibility in order eligibility validator Nov 24, 2025
@Rafikooo Rafikooo changed the title Validate product's channel eligibility in order eligibility validator Validate product's channel eligibility when finalizing an order Nov 24, 2025
@Rafikooo Rafikooo merged commit 78ab212 into Sylius:1.14 Nov 25, 2025
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Api] OrderProductEligibilityValidator missing check if product has current order channel, which allows to purchase "disabled" product

3 participants