Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Documentation] Non-existent action used#8697

Merged
pamil merged 1 commit into
Sylius:1.0from
kate-kate:patch-2
Sep 20, 2017
Merged

[Documentation] Non-existent action used#8697
pamil merged 1 commit into
Sylius:1.0from
kate-kate:patch-2

Conversation

@kate-kate
Copy link
Copy Markdown
Contributor

@kate-kate kate-kate commented Sep 19, 2017

There is no any completeAction in source file (ShopBundle/Resources/config/routing/checkout.yml)
Also there is no such action in OrderController or its ancestors, so it cause error

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets -
License MIT

@lchrusciel lchrusciel added this to the 1.0 milestone Sep 19, 2017
@lchrusciel lchrusciel added Bug Fix Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Sep 19, 2017
@lchrusciel lchrusciel changed the base branch from master to 1.0 September 19, 2017 15:07
@Zales0123
Copy link
Copy Markdown
Contributor

Unfortunately, we need a rebase to 1.0 branch there :/ Bug fix should be based on this branch since we released a 1.0.0 version. I hope that we'll be able to provide some documentation to what branch which PR should be opened (as mentioned in #8693).

There is no any ```completeAction``` in source file (ShopBundle/Resources/config/routing/checkout.yml) 
Also there is no such action in ```OrderController``` or its ancestors, so it cause error
@kate-kate
Copy link
Copy Markdown
Contributor Author

Done?

@pamil pamil merged commit c5ad6c8 into Sylius:1.0 Sep 20, 2017
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Sep 20, 2017

Thanks Kate! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants