Codestin Search App

GSadee · 2017-09-26T08:20:14Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Related tickets	partially fixes #8308
License	MIT

This PR fixes losing reference to an attribute value on a product when select attribute choice value renames.

pamil · 2017-09-26T12:12:15Z

Can we split these two fixes to two standalone PRs? Would be easier to review & merge then :)

pamil · 2017-09-26T12:18:21Z

Btw. as these are bugfixes, it should be targeted against 1.0

pamil · 2017-09-28T11:47:01Z

+        string $productAttributeType,
+        string $productAttributeName,
+        string $attributeValue,
+        string $language = 'en_US'


Isn't the language set to the last "([^"]+)"?

pamil · 2017-09-28T11:48:55Z

+    ) {
+        $attribute = $this->provideProductAttribute($productAttributeType, $productAttributeName);
+        $attribute->setConfiguration(['multiple' => false, 'choices' => [$attributeValue], 'min' => null, 'max' => null]);
+        $attributeValue = $this->createProductAttributeValue(array_keys($values), $attribute, $language);


Where's $values defined?

pamil · 2017-09-28T11:49:06Z

+    /**
+     * @Given /^(this product) has (.+?) attribute "([^"]+)" with value "([^"]+)", "([^"]+)"$/
+     */
+    public function thisProductHasSelectAttributeWithValue(


Looks like an abandoned step.

pamil · 2017-09-28T11:51:39Z

@@ -232,6 +253,25 @@ public function iWantToSeeAllProductAttributesInStore()
        $this->indexPage->open();
    }



It doesn't feel right reading this step, what about the something like: the administrator changes this product attribute value "foo" to "bar"?

pamil · 2017-09-28T11:56:00Z

     * @return string
     */
-    private function getValidFormKey(string $value): string
+    private function getValidFormKey(): string


getValidFormKey -> getUniqueKey?

pamil · 2017-09-28T11:57:12Z

-            "green": "green",
-            "black": "black"
-        },
+        "choices": @array@,


IMO we should change it to something like:

{ "@string@": "yellow", "@string@": "green", // etc.. }

I know and I agree that current example doesn't check behaviour properly, but this feature is not implemented in php-matcher (there is even an issue: coduo/php-matcher#92)

What about adding an additional assertion in the test file, eg. asserting that the response matches this file contents + getting $response['configuration']['choices'] and asserting they are what we expect (like https://github.com/Sylius/SyliusElasticSearchPlugin/blob/master/tests/Controller/SearchControllerApiTest.php#L436)?

pamil · 2017-09-28T12:01:29Z

+        And I specify its code as "mug_material"
        And I name it "Mug material" in "English (United States)"
-        And I add material "-100% Banana Skin"
+        And I add value "-100% Banana Skin"


Value is kinda misleading, my first - AttributeValue, the second - the same. What about naming it an "option" or a "select option"?

But we have values in configuration of a product attribute, so I wanted to be consistent with the layout:

I see the reasoning behind it, but it's still confusing, not sure whether we should solve it already or leave it as is :)

…tribute

… attribute

pamil

Let's fix that API test and it's good to go! 🎉

pamil · 2017-09-29T08:25:15Z

+        And I specify its code as "mug_material"
        And I name it "Mug material" in "English (United States)"
-        And I add material "-100% Banana Skin"
+        And I add value "-100% Banana Skin"


I see the reasoning behind it, but it's still confusing, not sure whether we should solve it already or leave it as is :)

pamil · 2017-09-29T08:36:50Z

-            "green": "green",
-            "black": "black"
-        },
+        "choices": @array@,


What about adding an additional assertion in the test file, eg. asserting that the response matches this file contents + getting $response['configuration']['choices'] and asserting they are what we expect (like https://github.com/Sylius/SyliusElasticSearchPlugin/blob/master/tests/Controller/SearchControllerApiTest.php#L436)?

pamil · 2017-09-29T11:06:16Z

Thank you Rzegś! 🎉

GSadee added the Bug Fix label Sep 26, 2017

GSadee added this to the 1.1 milestone Sep 26, 2017

GSadee force-pushed the select-attribute-rename-fix branch from 787fabd to bd7d87c Compare September 26, 2017 11:16

GSadee force-pushed the select-attribute-rename-fix branch from bd7d87c to 9c4dd2d Compare September 26, 2017 12:18

pamil modified the milestones: 1.1, 1.0 Sep 26, 2017

pamil changed the base branch from master to 1.0 September 26, 2017 12:18

GSadee changed the title ~~[WIP][ProductAttribute] Select product attribute fixes~~ [ProductAttribute] Fix select product attribute value rename Sep 26, 2017

GSadee force-pushed the select-attribute-rename-fix branch 3 times, most recently from b7f8395 to e209bae Compare September 27, 2017 06:51

pamil suggested changes Sep 28, 2017

View reviewed changes

GSadee added 3 commits September 28, 2017 15:44

[Behat][ProductAttribute] Add scenarios for editing select product at…

0d85173

…tribute

[ProductAttribute] Add uuid as a code for choices of a select product…

59b1375

… attribute

[ProductAttribute] Fixes after PR review

32583a8

GSadee force-pushed the select-attribute-rename-fix branch from e209bae to 32583a8 Compare September 28, 2017 13:56

GSadee changed the title ~~[ProductAttribute] Fix select product attribute value rename~~ [ProductAttribute] Fix select product attribute choice value rename Sep 29, 2017

GSadee mentioned this pull request Sep 29, 2017

[ProductAttribute] Fix select product attribute choice value delete #8751

Merged

pamil suggested changes Sep 29, 2017

View reviewed changes

Fix asserting select choices in unit test

6821ddd

pamil approved these changes Sep 29, 2017

View reviewed changes

pamil merged commit dee7829 into Sylius:1.0 Sep 29, 2017

GSadee deleted the select-attribute-rename-fix branch September 29, 2017 11:28

		@@ -232,6 +253,25 @@ public function iWantToSeeAllProductAttributesInStore()
		$this->indexPage->open();
		}

Uh oh!

Conversation

GSadee commented Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pamil commented Sep 26, 2017

Uh oh!

pamil commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pamil left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pamil commented Sep 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GSadee commented Sep 26, 2017 •

edited

Loading

pamil commented Sep 29, 2017 •

edited

Loading