[Documentation][Locale] Component docs fix#8826
Merged
Merged
Conversation
pamil
reviewed
Oct 12, 2017
| ~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| It is a composite of different contexts available in your application, which are prioritized while being injected here (the one with highest priority is used). | ||
| It has the ``getLocaleCode``, ``_construct()``, and ``addContext(LocaleContextInterface $localeContext, int $priority)`` methods available. |
Contributor
There was a problem hiding this comment.
This line is quite fragile and can be replaced by looking at the source code instead.
| ~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| It is a composite of different contexts available in your application, which are prioritized while being injected here (the one with highest priority is used). | ||
| It has the ``getLocaleCode``, ``_construct()``, and ``addContext(LocaleContextInterface $localeContext, int $priority)`` methods available. |
Contributor
There was a problem hiding this comment.
Anyway, _construct() -> __construct() and getLocaleCode -> getLocaleCode() if we decide to keep it
12cad2b to
419b0f2
Compare
GSadee
approved these changes
Oct 12, 2017
Contributor
|
Thank you @nightrainlily and @CoderMaggie! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes thanks to @nightrainlily who is our first time contributor 🔥 ! I just made a rebase here :D