Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added missing return type in customization/controller docs#8842

Merged
GSadee merged 1 commit into
Sylius:1.0from
mateuszsip:docs/exampl-missing-return-type
Oct 15, 2017
Merged

Added missing return type in customization/controller docs#8842
GSadee merged 1 commit into
Sylius:1.0from
mateuszsip:docs/exampl-missing-return-type

Conversation

@mateuszsip
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #8834
License MIT

Fixes #8834.

@GSadee GSadee added Bug Fix Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Oct 15, 2017
@GSadee GSadee added this to the 1.0 milestone Oct 15, 2017
@GSadee GSadee changed the base branch from master to 1.0 October 15, 2017 07:49
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Oct 15, 2017

Hi @kejwmen! Thank you for your contribution, you chose a good branch in the table, but unfortunately you created a PR to the wrong base branch, I've changed that to 1.0, so please rebase with this branch.

@mateuszsip mateuszsip force-pushed the docs/exampl-missing-return-type branch from 91dfb03 to 401824f Compare October 15, 2017 11:20
@mateuszsip
Copy link
Copy Markdown
Contributor Author

@GSadee sorry, now it's ok.

@GSadee GSadee merged commit 05c3755 into Sylius:1.0 Oct 15, 2017
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Oct 15, 2017

Thank you @kejwmen 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants