Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improved parse alias exception message#8924

Merged
pamil merged 2 commits into
Sylius:1.0from
11mb:improved_parseAlias_exception_message
Nov 10, 2017
Merged

Improved parse alias exception message#8924
pamil merged 2 commits into
Sylius:1.0from
11mb:improved_parseAlias_exception_message

Conversation

@11mb
Copy link
Copy Markdown
Contributor

@11mb 11mb commented Nov 1, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

Small contribution to make the exception thrown in the Metadata resource more explanatory. When an Exception is thrown: "Invalid alias", the alias is now included in the Exception message, which makes debugging much easier.

@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 2, 2017
@pamil pamil changed the base branch from master to 1.0 November 6, 2017 13:49
@pamil pamil added this to the 1.0 milestone Nov 6, 2017
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Nov 6, 2017

Needs to be rebased onto 1.0 branch, otherwise it's good to go! :)

@pamil pamil merged commit 919cf8d into Sylius:1.0 Nov 10, 2017
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Nov 10, 2017

Thanks @11mb, welcome to the community! 🎉

@11mb
Copy link
Copy Markdown
Contributor Author

11mb commented Nov 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Issues and PRs aimed at improving Developer eXperience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants