[Documentation][Cookbook]Adding validation for image uploads#9194
Merged
Conversation
CoderMaggie
reviewed
Feb 20, 2018
| minHeight: 200 | ||
| minWidth: 200 | ||
|
|
||
| This defines the validation constraints for each image entity. Now connecting the validation of the ShippingMethod to the validation of each single Image Entity is left: |
Member
There was a problem hiding this comment.
can we break this line? it's a bit too long :)
| - "image/jpg" | ||
| - "image/jpeg" | ||
| - "image/gif" | ||
| mimeTypesMessage: 'This mime is not allowed. Pls. use PNG, JPG or GIF files.' |
Member
There was a problem hiding this comment.
Pls. -> Please
This mime -> This file format
Member
|
Can you please rebase your PR with the |
Adding description on how to validate the images that can be uploaded when finishing this guide.
pamil
reviewed
Feb 26, 2018
| Your form so far is working fine, but don't forget about validation. | ||
| The easiest way is using validation config files under the ``AppBundle/Resources/config/validation`` folder. | ||
|
|
||
| This could look like this f.i.: |
| minWidth: 200 | ||
|
|
||
| This defines the validation constraints for each image entity. | ||
| Now connecting the validation of the ``ShippingMethod`` to the validation of each single ``Image Entity`` is left: |
Contributor
There was a problem hiding this comment.
I'm missing the information what file should I modify here.
CoderMaggie
reviewed
Feb 27, 2018
CoderMaggie
approved these changes
Feb 28, 2018
Contributor
|
Thanks @Mipme! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding description on how to validate the images that can be uploaded when finishing this guide.