Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Grid] Default parameters for "default" grid action#9349

Merged
pamil merged 1 commit into
Sylius:1.0from
Zales0123:default-parameters-for-grid-default-action-route
Apr 19, 2018
Merged

[Grid] Default parameters for "default" grid action#9349
pamil merged 1 commit into
Sylius:1.0from
Zales0123:default-parameters-for-grid-default-action-route

Conversation

@Zales0123
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 commented Apr 18, 2018

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

With previous implementation, it was required to pass parameters even if action route does not require any:

actions:
    main:
        destroy_ring:
            type: default
            options:
                link:
                    route: sylius_destroy_ring
                    parameters: {}

Now not passing paremeters does not result in twig error.

actions:
    main:
        destroy_ring:
            type: default
            options:
                link:
                    route: sylius_destroy_ring

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 18, 2018
@pamil pamil merged commit a1e9694 into Sylius:1.0 Apr 19, 2018
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 19, 2018

Thanks, Mateusz 🎉

@Zales0123 Zales0123 deleted the default-parameters-for-grid-default-action-route branch April 19, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pamil pamil pamil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zales0123 @pamil