Adding strict typing for PHP classes in images doc#9587
Merged
Conversation
lchrusciel
approved these changes
Jul 13, 2018
CoderMaggie
approved these changes
Jul 13, 2018
Member
|
Hi there @Roshyo, nice to see you in our community as a contributor 👋 💪! One thing that we need to change here is the base branch of this PR. It should be opened to the |
Contributor
Author
|
@CoderMaggie Hi, I'm ok with that, but since I'm definitely not familiar with GitHub (boooh shame on me) I'm not sure about how to do that. Can you help me ? |
Contributor
|
@CoderMaggie @Roshyo I'll do it for you :) |
This part of the doc was lacking strict PHP typing.
Contributor
|
Thank you, Stephane! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part of the doc was lacking strict PHP typing.
Adding strict typing for the cookbook in images.