Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Shop] Fix password request & contact pages with a mobile view.#9805

Merged
pamil merged 1 commit into
Sylius:1.2from
versgui:fix-responsive
Oct 11, 2018
Merged

[Shop] Fix password request & contact pages with a mobile view.#9805
pamil merged 1 commit into
Sylius:1.2from
versgui:fix-responsive

Conversation

@versgui
Copy link
Copy Markdown

@versgui versgui commented Oct 9, 2018

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Fix a small issue on the password request and contact pages, with a mobile view.

46560774-3f56dc80-c8f5-11e8-8322-b0c8197143f4

@versgui versgui requested a review from a team as a code owner October 9, 2018 20:58
@versgui versgui changed the title [Shop] Fix a small issue on the password request page, with a mobile view. [Shop] Fix password request & contact pages with a mobile view. Oct 9, 2018
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that provided screenshot is before the fix 😄 Could you also provide screenshot after the fix? Thanks!

@Zales0123 Zales0123 added the Shop ShopBundle related issues and PRs. label Oct 10, 2018
@versgui
Copy link
Copy Markdown
Author

versgui commented Oct 10, 2018

@Zales0123 Of course :)
I added a "stackable" CSS Class so the content is wide on mobile.

After the fix :
screenshot_2018-10-10 sylius

@lchrusciel lchrusciel changed the base branch from 1.3 to 1.2 October 11, 2018 07:25
@Zales0123
Copy link
Copy Markdown
Contributor

Could you please rebase to branch 1.2? thanks :)

@pamil
Copy link
Copy Markdown
Contributor

pamil commented Oct 11, 2018

Rebased it so you don't have to :)

@pamil pamil merged commit 88625ad into Sylius:1.2 Oct 11, 2018
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Oct 11, 2018

Thank you, Guillaume! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Shop ShopBundle related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants