SensioGeneratorBundle vs SymfonyMakerBundle#9830
Merged
Merged
Conversation
Sensio Generator Bundle does not support Symfony 4, and we should use the Maker Bundle as it's stated here https://github.com/sensiolabs/SensioGeneratorBundle
Contributor
|
Thanks for the PR! I feel like it's a good move to switch to recommending the MakerBundle in Sylius 1.3. Could you also update the rest of that file with instructions for MakerBundle? It's okay if you couldn't, then I'd merge this one and do it myself probably :) |
Contributor
Author
|
Yeah no problem, i'll add some infos about the MakerBundle :) |
add step for creating an entity with the maker bundle
Contributor
Author
|
Done! |
lchrusciel
approved these changes
Oct 17, 2018
pamil
approved these changes
Oct 18, 2018
Contributor
|
Thank you, David! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sensio Generator Bundle does not support Symfony 4, and we should use the Maker Bundle as it's stated here https://github.com/sensiolabs/SensioGeneratorBundle