Feature update livetime correction add pileup parameter calculation.#100
Merged
samaloney merged 2 commits intoApr 30, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 62.12% 62.50% +0.38%
==========================================
Files 29 29
Lines 1769 1779 +10
==========================================
+ Hits 1099 1112 +13
+ Misses 670 667 -3 ☔ View full report in Codecov by Sentry. |
133751e to
0fde7ea
Compare
paolomassa
approved these changes
Apr 30, 2024
1 task
Contributor
|
It would be really great to have the livetime and pileup corrections applied directly to the data when creating a product with product factory, like for cpd and spectrogram products. In a similar way as is done for quicklook data: stixpy/stixpy/timeseries/quicklook.py Line 139 in e3d8d61 and also in the imaging pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.