Make compatible with xrayvision.visibility.Visibilities#123
Merged
Conversation
samaloney
approved these changes
May 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 31 31
Lines 1856 1856
=======================================
Hits 1347 1347
Misses 509 509 ☔ View full report in Codecov by Sentry. |
Member
|
So I think the doc build fails are because the PR on xrayvision wasn't merged. I proded the doc_build test if that passses will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge before TCDSolar/xrayvision/pull/67
Make the imaging demo compatible with the new
xrayvision.visibility.Visibilitiesclass. To be merged after #67.