Update for new Visibilities object and some tidy#124
Merged
Conversation
samaloney
commented
Jun 2, 2024
Member
- Upate internal code for new vis object
- Update imaging demo to use new vis object feature (slice, meta)
- Small tidy ups
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 72.57% 72.30% -0.28%
==========================================
Files 31 31
Lines 1856 1892 +36
==========================================
+ Hits 1347 1368 +21
- Misses 509 524 +15 ☔ View full report in Codecov by Sentry. |
paolomassa
reviewed
Jun 3, 2024
| rotation_angle=90 * u.deg + roll, | ||
| ) | ||
|
|
||
| clean_map = Map((clean_map.data, header)) |
Contributor
There was a problem hiding this comment.
Why is the map created outside of clean? Is it possible to make it inside as for the other methods?
Member
Author
There was a problem hiding this comment.
Currently vis_clean makes a map assuming helioprojective which in this case is not correct.
Member
Author
There was a problem hiding this comment.
Essentially once TCDSolar/xrayvision/issues/56 is done issue is resolved this won't be necessary
DanRyanIrish
reviewed
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.