Adding additions checks for other pixel bin conditions for timerange for create_meta_pixel#138
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 73.50% 73.56% +0.05%
==========================================
Files 32 32
Lines 2012 2016 +4
==========================================
+ Hits 1479 1483 +4
Misses 533 533 ☔ View full report in Codecov by Sentry. |
create_meta_pixelcreate_meta_pixel
Contributor
Author
|
this is ready for review |
samaloney
reviewed
Sep 2, 2024
samaloney
left a comment
Member
There was a problem hiding this comment.
Looks good to me sorry for the delay.
samaloney
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133