Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix grid transmission#146

Merged
samaloney merged 2 commits into
TCDSolar:mainfrom
samaloney:bugfix-grid-transmission
Nov 19, 2024
Merged

Bugfix grid transmission#146
samaloney merged 2 commits into
TCDSolar:mainfrom
samaloney:bugfix-grid-transmission

Conversation

@samaloney

@samaloney samaloney commented Oct 15, 2024

Copy link
Copy Markdown
Member

The grid orientation angle do not have to be "flipped" by 180 deg when we compute the offset angle of the flare location relative to the slats (in arcseconds). The grid orientation angles are indeed defined as in Figure 2 of The STIX Imaging Concept paper (Massa et al., 2023).

@codecov

codecov Bot commented Oct 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (f30588c) to head (4048a16).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   73.56%   73.56%           
=======================================
  Files          32       32           
  Lines        2016     2016           
=======================================
  Hits         1483     1483           
  Misses        533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanRyanIrish

Copy link
Copy Markdown
Contributor

Looks like this branch has been merged with other branches not in main...

@samaloney

Copy link
Copy Markdown
Member Author

Yea #141 planned to merge that one first

@samaloney samaloney force-pushed the bugfix-grid-transmission branch from 7deb9d7 to 6d25e92 Compare November 19, 2024 15:28
@samaloney samaloney merged commit 95c342b into TCDSolar:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants