Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable Meta Pixels to be generated from just top or bottom pixels#148

Merged
samaloney merged 9 commits into
TCDSolar:mainfrom
DanRyanIrish:vis_pixel_subset
Feb 10, 2025
Merged

Enable Meta Pixels to be generated from just top or bottom pixels#148
samaloney merged 9 commits into
TCDSolar:mainfrom
DanRyanIrish:vis_pixel_subset

Conversation

@DanRyanIrish

Copy link
Copy Markdown
Contributor

This PR enables users to generate their meta pixels for use in calculating STIX visibilities by only using top or bottom big pixels. This is needed in cases where the flare occurred at the edge of the STIX FOV, resulting in one row of pixels not being fully illuminated.

@codecov

codecov Bot commented Nov 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (5dbfc0b) to head (7794e76).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/calibration/visibility.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   73.56%   74.47%   +0.90%     
==========================================
  Files          32       32              
  Lines        2016     2029      +13     
==========================================
+ Hits         1483     1511      +28     
+ Misses        533      518      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanRyanIrish

Copy link
Copy Markdown
Contributor Author

ping @samaloney for a review.

Comment thread stixpy/calibration/visibility.py Outdated
Comment thread stixpy/calibration/visibility.py Outdated
Comment thread stixpy/coordinates/tests/test_transforms.py
@samaloney

Copy link
Copy Markdown
Member

@DanRyanIrish made some small changes I'll merge if you are happy?

@samaloney samaloney merged commit 0c6d21e into TCDSolar:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants