Maint: Update project configuration and add zenodo and mailman configs#158
Merged
Conversation
* Move config from setup.cfg to individual config files for each tool (isort, ruff, pytest, etc) * Add zenodo and mailmap config files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 75.50% 75.42% -0.09%
==========================================
Files 32 33 +1
Lines 2111 2116 +5
==========================================
+ Hits 1594 1596 +2
- Misses 517 520 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0ea997e to
1f43937
Compare
samaloney
commented
Apr 2, 2025
Comment on lines
226
to
227
| ("L1", "STIX: Engineering and UTC time conversion ."), | ||
| ("ANC", "STIX: Ancillary Data like aspect."), | ||
| ("L2", "STIX: Calibrated data."), | ||
| ("ANC", "STIX: Ancillary data."), |
Member
Author
There was a problem hiding this comment.
@nicHoch I think the ANC level attr was in twice so I removed it but that seem to change a few of the test by 1 which I have assumed was an extra entry for the second ANC
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s configuration by migrating settings from setup.cfg to project.toml and related files, updates versioning and build settings, and adds new config files (.zenodo.json and .mailmap).
- Migrate configuration to pyproject.toml and other dedicated config files
- Update build backend and dependency versions
- Remove legacy setup.py and cleanup configuration files
Reviewed Changes
Copilot reviewed 20 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| stixpy/net/client.py | Clean up duplicate and concatenated string definitions |
| stixpy/coordinates/transforms.py | Simplify warning message string concatenation |
| stixpy/calibration/transmission.py | Refine error message formatting in value checks |
| stixpy/calibration/tests/test_energy.py | Remove string concatenation artifacts in test data |
| stixpy/calibration/compression.py | Standardize f-string formatting for error messages |
| stixpy/_dev/scm_version.py | Introduce SCM version handling for development installations |
| stixpy/init.py | Update version import for clarity |
| setup.py | Remove obsolete setup script |
| ruff.toml | Adjust linting rules by removing PT004 and updating exclusions |
| pyproject.toml | Update dependency versions and project metadata |
| .pre-commit-config.yaml | Update pre-commit hook revisions and exclusions |
Files not reviewed (8)
- .codespellrc: Language not supported
- .coveragerc: Language not supported
- .isort.cfg: Language not supported
- .mailmap: Language not supported
- .zenodo.json: Language not supported
- changelog/158.trivial.rst: Language not supported
- pytest.ini: Language not supported
- setup.cfg: Language not supported
Comments suppressed due to low confidence (1)
pyproject.toml:10
- The project name 'stixypy' appears inconsistent with the module naming in 'stixpy'. Please verify the intended project name for consistency.
name = "stixypy"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.