refactor to remove constant pixel area and adc-pairing to configuration driven#171
Merged
Merged
Conversation
Member
|
So I think the corresponding change to the STIX-CONF repo are missing or there no PR at least? |
289e0a0 to
03144c2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 76.76% 76.93% +0.16%
==========================================
Files 33 34 +1
Lines 2126 2146 +20
==========================================
+ Hits 1632 1651 +19
- Misses 494 495 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7467971 to
4aca824
Compare
4aca824 to
7afb8c6
Compare
samaloney
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some magic and constant numbers where implemented as constants in methods. The pixel area and adc detector pairing is now moved to the stix-conf submodule.
Readers and a instrument module constant have been implemented