Update default location in imaging demo#173
Merged
Merged
Conversation
25d7b9d to
f9f5042
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 75.51% 76.76% +1.24%
==========================================
Files 33 33
Lines 2124 2126 +2
==========================================
+ Hits 1604 1632 +28
+ Misses 520 494 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f9f5042 to
3be42c9
Compare
3be42c9 to
050e139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current default leads to incorrect results, which is only really obvious when SO has a large offprinting. This PR updates the imaging demo to show use sun centre pointing as the default for producing correct behaviour.
Closes #139