Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Fido client not finding data which contains midnight#176

Merged
samaloney merged 1 commit into
TCDSolar:mainfrom
samaloney:bugfix-spec-day-boundary
Aug 28, 2025
Merged

Fix Fido client not finding data which contains midnight#176
samaloney merged 1 commit into
TCDSolar:mainfrom
samaloney:bugfix-spec-day-boundary

Conversation

@samaloney

@samaloney samaloney commented Aug 7, 2025

Copy link
Copy Markdown
Member

Closes #168 by update the code to extend search window and hence paths searched by 6.5 hours before the requested start time. As due to the way the archive is populated requests are located in the directory structure base on their start time. While the TM could support request of ~19days - operationally don't make request larger than ~6 hours.

@samaloney samaloney force-pushed the bugfix-spec-day-boundary branch from c271c9c to c556e64 Compare August 7, 2025 10:34
@samaloney samaloney force-pushed the bugfix-spec-day-boundary branch from c556e64 to c58bfd9 Compare August 7, 2025 10:36
@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.96%. Comparing base (8cf6a20) to head (c58bfd9).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/net/client.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   76.93%   76.96%   +0.03%     
==========================================
  Files          34       34              
  Lines        2146     2149       +3     
==========================================
+ Hits         1651     1654       +3     
  Misses        495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samaloney samaloney merged commit cd5193d into TCDSolar:main Aug 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fido client misses some data if it extends over two dates

1 participant